Skip to content

GCSFileTransformOperator: New templated fields source_object, destination_object#23328

Merged
eladkal merged 2 commits into
apache:mainfrom
eladkal:23327
Apr 28, 2022
Merged

GCSFileTransformOperator: New templated fields source_object, destination_object#23328
eladkal merged 2 commits into
apache:mainfrom
eladkal:23327

Conversation

@eladkal

@eladkal eladkal commented Apr 28, 2022

Copy link
Copy Markdown
Contributor
  • Add source_object, destination_object as templated fields
  • fix docstring

closes: #23327


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

…stination_object`

* Add `source_object`, `destination_object` as templated fields
* fix docstring
closes: apache#23327
@eladkal
eladkal requested a review from turbaszek as a code owner April 28, 2022 13:40
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Apr 28, 2022
Comment thread airflow/providers/google/cloud/operators/gcs.py Outdated
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 28, 2022
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal
eladkal merged commit c82b3b9 into apache:main Apr 28, 2022
@eladkal
eladkal deleted the 23327 branch April 28, 2022 17:07
@nitinmuteja

Copy link
Copy Markdown

Hi @eladkal ,
When do we expect the library release?

@eladkal

eladkal commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

probably sometime around beginning of May

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCSTransformOperator: provide Jinja templating in source and destination object names

3 participants